Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove page macro in RTC docs #13921

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Remove page macro in RTC docs #13921

merged 1 commit into from
Mar 16, 2022

Conversation

wbamberg
Copy link
Collaborator

Removes the last few usages of {{page}} in the WebRTC docs. In these cases the transcluded content was also linked, so it seems fine to use the link, as we do almost everywhere else. Part of #3196.

@wbamberg wbamberg requested a review from a team as a code owner March 15, 2022 20:54
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team March 15, 2022 20:54
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 15, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCRtpCapabilities
Title: RTCRtpCapabilities
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/API/RTCRtpHeaderExtensionCapability does not exist
    • /en-US/docs/Web/API/RTCRtpCodecCapability/mimeType does not exist
    • /en-US/docs/Web/API/RTCRtpCodecCapability/sdpFmtpLine does not exist
  • bad_bcd_queries:
    • No BCD data for query: api.RTCRtpCapabilities

External URLs

URL: /en-US/docs/Web/API/RTCRtpSendParameters/encodings
Title: RTCRtpSendParameters.encodings
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCRtpCapabilities
Title: RTCRtpCapabilities
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/RTCStatsReport
Title: RTCStatsReport
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 3ebb1fe into mdn:main Mar 16, 2022
@wbamberg wbamberg deleted the remove-rtc-page branch October 15, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbamberg @sideshowbarker